Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix descriptions #473

Merged
merged 4 commits into from
Dec 11, 2024
Merged

fix descriptions #473

merged 4 commits into from
Dec 11, 2024

Conversation

tariqkurd-repo
Copy link
Collaborator

@tariqkurd-repo tariqkurd-repo commented Dec 10, 2024 •
edited
Loading

tariqkurd-repo
tariqkurd-repo commented Dec 10, 2024
View reviewed changes
src/csv/CHERI_CSR.csv Outdated Show resolved Hide resolved
francislaus
francislaus suggested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@francislaus francislaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only spotted the line pointed out above.

src/csv/CHERI_ISA.csv Outdated Show resolved Hide resolved
arichardson
arichardson previously requested changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the issue with C.LCSP

@tariqkurd-repo tariqkurd-repo merged commit 8b6f7e4 into riscv:main Dec 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francislaus francislaus francislaus requested changes

@arichardson arichardson arichardson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tariqkurd-repo @arichardson @francislaus